dasha_uwu/PrismLauncher
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

refactor: make shared_qobject_ptr ctor explicit

Browse source 
This turns issues like creating two shared ptrs from a single raw ptr
from popping up at runtime, instead making them a compile error.

Signed-off-by: flow <flowlnlnln@gmail.com>
This commit is contained in:
flow 2023-01-24 16:52:09 -03:00
parent 5186ad95d3
commit 29f7ea752f
No known key found for this signature in database
GPG key ID: 8D0F221F0A59F469
63 changed files with 301 additions and 287 deletions
Download patch file Download diff file Expand all files Collapse all files

2
launcher/ui/dialogs/ResourceDownloadDialog.cpp
View file

@ -147,7 +147,7 @@ void ResourceDownloadDialog::addResource(ModPlatform::IndexedPack& pack, ModPlat
removeResource(pack, ver);
ver.is_currently_selected = true;
m_selected.insert(pack.name, new ResourceDownloadTask(pack, ver, getBaseModel(), is_indexed));
m_selected.insert(pack.name, makeShared<ResourceDownloadTask>(pack, ver, getBaseModel(), is_indexed));
m_buttons.button(QDialogButtonBox::Ok)->setEnabled(!m_selected.isEmpty());
}