dasha_uwu/PrismLauncher
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Resolve other switch fallthrough issues

Browse source
This commit is contained in:
PandaNinjas 2023-06-07 19:37:54 -04:00
parent 5d425ecc02
commit 318d11481d
No known key found for this signature in database
GPG key ID: 0BD7553044D47763
14 changed files with 60 additions and 74 deletions
Download patch file Download diff file Expand all files Collapse all files

3
launcher/minecraft/mod/Mod.cpp
View file

@ -89,6 +89,7 @@ std::pair<int, bool> Mod::compare(const Resource& other, SortType type) const
auto res = Resource::compare(other, type);
if (res.first != 0)
return res;
break;
}
case SortType::VERSION: {
auto this_ver = Version(version());
@ -97,11 +98,13 @@ std::pair<int, bool> Mod::compare(const Resource& other, SortType type) const
return { 1, type == SortType::VERSION };
if (this_ver < other_ver)
return { -1, type == SortType::VERSION };
break;
}
case SortType::PROVIDER: {
auto compare_result = QString::compare(provider().value_or("Unknown"), cast_other->provider().value_or("Unknown"), Qt::CaseInsensitive);
if (compare_result != 0)
return { compare_result, type == SortType::PROVIDER };
break;
}
}
return { 0, false };