From 491b5e147370189ec8553ef5819ece448f9cd9e3 Mon Sep 17 00:00:00 2001
From: TheKodeToad <TheKodeToad@proton.me>
Date: Mon, 24 Mar 2025 16:34:45 +0000
Subject: [PATCH] Correctly show max memory notice for max < min

Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
---
 launcher/ui/widgets/AppearanceWidget.ui    | 24 ++++++++++++++++++++++
 launcher/ui/widgets/JavaSettingsWidget.cpp |  1 +
 2 files changed, 25 insertions(+)

diff --git a/launcher/ui/widgets/AppearanceWidget.ui b/launcher/ui/widgets/AppearanceWidget.ui
index d646cb9e0..deb5a94d4 100644
--- a/launcher/ui/widgets/AppearanceWidget.ui
+++ b/launcher/ui/widgets/AppearanceWidget.ui
@@ -157,6 +157,18 @@
          </size>
         </property>
         <layout class="QHBoxLayout" name="horizontalLayout_2">
+         <property name="leftMargin">
+          <number>0</number>
+         </property>
+         <property name="topMargin">
+          <number>0</number>
+         </property>
+         <property name="rightMargin">
+          <number>0</number>
+         </property>
+         <property name="bottomMargin">
+          <number>0</number>
+         </property>
          <item>
           <widget class="QFontComboBox" name="consoleFont"/>
          </item>
@@ -208,6 +220,18 @@
          </size>
         </property>
         <layout class="QGridLayout" name="gridLayout_4">
+         <property name="leftMargin">
+          <number>0</number>
+         </property>
+         <property name="topMargin">
+          <number>0</number>
+         </property>
+         <property name="rightMargin">
+          <number>0</number>
+         </property>
+         <property name="bottomMargin">
+          <number>0</number>
+         </property>
          <item row="2" column="2">
           <spacer name="horizontalSpacer_4">
            <property name="orientation">
diff --git a/launcher/ui/widgets/JavaSettingsWidget.cpp b/launcher/ui/widgets/JavaSettingsWidget.cpp
index 265385d03..f5435d16f 100644
--- a/launcher/ui/widgets/JavaSettingsWidget.cpp
+++ b/launcher/ui/widgets/JavaSettingsWidget.cpp
@@ -299,6 +299,7 @@ void JavaSettingsWidget::updateThresholds()
         m_ui->labelMaxMemNotice->show();
     } else if (maxMem < minMem) {
         m_ui->labelMaxMemNotice->setText(warningColour.arg(tr("Your maximum memory allocation is below the minimum memory allocation.")));
+        m_ui->labelMaxMemNotice->show();
     } else {
         m_ui->labelMaxMemNotice->hide();
     }