dasha_uwu/PrismLauncher
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fixed some codeql warnings

Browse source 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
This commit is contained in:
Trial97 2024-01-30 12:37:34 +02:00
parent 7317105e4d
commit 5afe75e821
No known key found for this signature in database
GPG key ID: 55EF5DA53DB36318
11 changed files with 15 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

4
launcher/java/JavaInstallList.cpp
View file

@ -170,7 +170,7 @@ void JavaListLoadTask::executeTask()
int id = 0;
for (QString candidate : candidate_paths) {
auto checker = new JavaChecker(candidate, "", 0, 0, 0, id, this);
connect(checker, &JavaChecker::checkFinished, [this](JavaChecker::Result result) { m_results << result; });
connect(checker, &JavaChecker::checkFinished, [this](const JavaChecker::Result& result) { m_results << result; });
job->addTask(Task::Ptr(checker));
id++;
}
@ -181,7 +181,7 @@ void JavaListLoadTask::executeTask()
void JavaListLoadTask::javaCheckerFinished()
{
QList<JavaInstallPtr> candidates;
std::sort(m_results.begin(), m_results.end(), [](JavaChecker::Result a, JavaChecker::Result b) { return a.id < b.id; });
std::sort(m_results.begin(), m_results.end(), [](const JavaChecker::Result& a, const JavaChecker::Result& b) { return a.id < b.id; });
qDebug() << "Found the following valid Java installations:";
for (auto result : m_results) {