dasha_uwu/PrismLauncher
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix: don't use forward-declared Ptr types in meta/

Browse source 
This would cause ODR violations when those headers were included in
other places that also included stuff like "Version.h" (note the
"meta/Version.h"), which can cause problems, especially in LTO.

Signed-off-by: flow <flowlnlnln@gmail.com>
This commit is contained in:
flow 2022-11-01 19:48:26 -03:00
parent f6a3fa55b1
commit 7956e6f04e
No known key found for this signature in database
GPG key ID: 8D0F221F0A59F469
28 changed files with 120 additions and 118 deletions
Download patch file Download diff file Expand all files Collapse all files

2
launcher/ui/widgets/JavaSettingsWidget.cpp
View file

@ -245,7 +245,7 @@ void JavaSettingsWidget::memoryValueChanged(int)
}
}
void JavaSettingsWidget::javaVersionSelected(BaseVersionPtr version)
void JavaSettingsWidget::javaVersionSelected(BaseVersion::Ptr version)
{
auto java = std::dynamic_pointer_cast<JavaInstall>(version);
if(!java)