dasha_uwu/PrismLauncher
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

tidy: Fix clang-tidy issues on files changed in this PR

Browse source 
The checks used are roughly the same as the ones proposed in the
clang-tidy PR (except perhaps that I used modernize-* instead of listing
them individually,though I don't think this caused any readability
detriments).

In ModrinthModel.cpp and FlameModModel.cpp I ignored the
modernize-avoid-c-arrays one, mostly because making the sorts array an
std::array would most likely increase the code complexity because of the
virtual function. Aside from that, the static_cast warning from
Application.h was not dealt with, since it's not in this PR's scope.
This commit is contained in:
flow 2022-03-08 11:12:35 -03:00
parent b3c2a56ece
commit 8409aa2571
No known key found for this signature in database
GPG key ID: 8D0F221F0A59F469
20 changed files with 86 additions and 84 deletions
Download patch file Download diff file Expand all files Collapse all files

4
launcher/modplatform/helpers/NetworkModAPI.h
View file

@ -8,6 +8,6 @@ class NetworkModAPI : public ModAPI {
void getVersions(CallerType* caller, const QString& addonId) const override;
protected:
virtual QString getModSearchURL(SearchArgs& args) const = 0;
virtual QString getVersionsURL(const QString& addonId) const = 0;
virtual auto getModSearchURL(SearchArgs& args) const -> QString = 0;
virtual auto getVersionsURL(const QString& addonId) const -> QString = 0;
};