dasha_uwu/PrismLauncher
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

chore: fix some codeql warnings (#3840)

Browse source
This commit is contained in:
Tayou 2025-06-06 14:19:27 +02:00 • committed by GitHub
commit a17ea196c1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
18 changed files with 72 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

1
launcher/ui/pages/modplatform/flame/FlameModel.cpp
View file

@ -79,6 +79,7 @@ bool ListModel::setData(const QModelIndex& index, const QVariant& value, [[maybe
if (pos >= modpacks.size() || pos < 0 || !index.isValid())
return false;
Q_ASSERT(value.canConvert<Flame::IndexedPack>());
modpacks[pos] = value.value<Flame::IndexedPack>();
return true;

4
launcher/ui/pages/modplatform/flame/FlamePage.cpp
View file

@ -166,7 +166,9 @@ void FlamePage::onSelectionChanged(QModelIndex curr, [[maybe_unused]] QModelInde
return;
}
current = listModel->data(curr, Qt::UserRole).value<Flame::IndexedPack>();
QVariant raw = listModel->data(curr, Qt::UserRole);
Q_ASSERT(raw.canConvert<Flame::IndexedPack>());
current = raw.value<Flame::IndexedPack>();
if (!current.versionsLoaded || m_filterWidget->changed()) {
qDebug() << "Loading flame modpack versions";