From 56fa6586abe6b90dbecf603efafa79b1a9b0647b Mon Sep 17 00:00:00 2001 From: Seth Flynn Date: Thu, 3 Jul 2025 01:15:29 -0400 Subject: [PATCH 1/2] fix(ui/CustomCommands): memory corruption in labelPostExitCmd Making a QLabel a buddy of itself causes a double free and crashing on deconstruction in some cases (like MSVC) Signed-off-by: Seth Flynn --- launcher/ui/widgets/CustomCommands.ui | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/launcher/ui/widgets/CustomCommands.ui b/launcher/ui/widgets/CustomCommands.ui index c1b4558a8..6c1366c06 100644 --- a/launcher/ui/widgets/CustomCommands.ui +++ b/launcher/ui/widgets/CustomCommands.ui @@ -86,7 +86,7 @@ P&ost-exit Command - labelPostExitCmd + postExitCmdTextBox From 364ebbcbe63b13e21f1640deaf05b0c8dcd21eee Mon Sep 17 00:00:00 2001 From: Seth Flynn Date: Thu, 3 Jul 2025 01:25:49 -0400 Subject: [PATCH 2/2] ci: run on changes to .ui files Signed-off-by: Seth Flynn --- .github/workflows/build.yml | 1 + .github/workflows/codeql.yml | 1 + .github/workflows/flatpak.yml | 1 + .github/workflows/nix.yml | 1 + 4 files changed, 4 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 98be31627..4954328a9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -10,6 +10,7 @@ on: - "**.cpp" - "**.h" - "**.java" + - "**.ui" # Directories - "buildconfig/" diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 8df64878b..f14bacc02 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -10,6 +10,7 @@ on: - "**.cpp" - "**.h" - "**.java" + - "**.ui" # Directories - "buildconfig/" diff --git a/.github/workflows/flatpak.yml b/.github/workflows/flatpak.yml index 26a44d679..dcfd2ea14 100644 --- a/.github/workflows/flatpak.yml +++ b/.github/workflows/flatpak.yml @@ -13,6 +13,7 @@ on: - "**.cpp" - "**.h" - "**.java" + - "**.ui" # Build files - "flatpak/" diff --git a/.github/workflows/nix.yml b/.github/workflows/nix.yml index 7b9412c87..702f8df28 100644 --- a/.github/workflows/nix.yml +++ b/.github/workflows/nix.yml @@ -12,6 +12,7 @@ on: - "**.cpp" - "**.h" - "**.java" + - "**.ui" # Build files - "**.nix"