dasha_uwu/PrismLauncher
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Apply suggestions from code review

Browse source 
Co-authored-by: DioEgizio <83089242+DioEgizio@users.noreply.github.com>
Signed-off-by: Alexandru Ionut Tripon <alexandru.tripon97@gmail.com>
This commit is contained in:
Alexandru Ionut Tripon 2024-02-26 22:00:40 +02:00 • committed by GitHub
parent 1c96ae5807
commit da96172b0b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
launcher/ui/widgets/JavaSettingsWidget.cpp
View file

@ -173,8 +173,8 @@ void JavaSettingsWidget::initialize()
updateThresholds();
auto button = CustomMessageBox::selectable(this, tr("Auto Java Download"),
tr("%1 has now the ability to auto downloand the correct java for each minecraft version.\n"
"Do you want to enable java auto-download?\n")
tr("%1 can automatically download the correct Java version for each version of Minecraft..\n"
"Do you want to enable Java auto-download?\n")
.arg(BuildConfig.LAUNCHER_DISPLAYNAME),
QMessageBox::Warning, QMessageBox::Yes | QMessageBox::No, QMessageBox::Yes)
->exec();
@ -505,7 +505,7 @@ void JavaSettingsWidget::updateThresholds()
} else if (observedMaxMemory > 2048 && m_result.is_64bit) {
iconName = "status-bad";
m_labelMaxMemIcon->setToolTip(
tr("Your maximum memory allocation exceeds selected java possible memory(due to x86 application limitations)."));
tr("Because you're using 32 bit Java, you're exceeding the maximum possible allocation."));
} else {
iconName = "status-good";
m_labelMaxMemIcon->setToolTip("");