chore: fix some codeql warnings (#3838)

launcher/SysInfo.h

@@ -1,3 +1,4 @@
+#pragma once
 #include <QString>
 
 namespace SysInfo {

launcher/logs/LogParser.h

@@ -16,7 +16,7 @@
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  *
  */
-
+#pragma once
 #include <QAnyStringView>
 #include <QDateTime>
 #include <QList>

launcher/minecraft/AssetsUtils.cpp

@@ -159,7 +159,7 @@ bool loadAssetsIndexJson(const QString& assetsId, const QString& path, AssetsInd
             if (key == "hash") {
                 object.hash = value.toString();
             } else if (key == "size") {
-                object.size = value.toDouble();
+                object.size = value.toLongLong();
             }
         }
 

launcher/minecraft/Component.cpp

@@ -462,7 +462,7 @@ void Component::waitLoadMeta()
     }
 }
 
-void Component::setUpdateAction(UpdateAction action)
+void Component::setUpdateAction(const UpdateAction& action)
 {
     m_updateAction = action;
 }

launcher/minecraft/Component.h

@@ -106,7 +106,7 @@ class Component : public QObject, public ProblemProvider {
 
     void waitLoadMeta();
 
-    void setUpdateAction(UpdateAction action);
+    void setUpdateAction(const UpdateAction& action);
     void clearUpdateAction();
     UpdateAction getUpdateAction();
 

launcher/minecraft/ComponentUpdateTask.cpp

@@ -570,7 +570,7 @@ void ComponentUpdateTask::performUpdateActions()
                               component->setVersion(cv.targetVersion);
                               component->waitLoadMeta();
                           },
-                          [&component, &instance](const UpdateActionLatestRecommendedCompatible lrc) {
+                          [&component, &instance](const UpdateActionLatestRecommendedCompatible& lrc) {
                               qCDebug(instanceProfileResolveC)
                                   << instance->name() << "|"
                                   << "UpdateActionLatestRecommendedCompatible" << component->getID() << ":" << component->getVersion()

launcher/minecraft/auth/AccountData.cpp

@@ -41,7 +41,7 @@
 #include <QUuid>
 
 namespace {
-void tokenToJSONV3(QJsonObject& parent, Token t, const char* tokenName)
+void tokenToJSONV3(QJsonObject& parent, const Token& t, const char* tokenName)
 {
     if (!t.persistent) {
         return;

launcher/minecraft/mod/tasks/GetModDependenciesTask.cpp

@@ -87,7 +87,7 @@ ModPlatform::Dependency GetModDependenciesTask::getOverride(const ModPlatform::D
 {
     if (auto isQuilt = m_loaderType & ModPlatform::Quilt; isQuilt || m_loaderType & ModPlatform::Fabric) {
         auto overide = ModPlatform::getOverrideDeps();
-        auto over = std::find_if(overide.cbegin(), overide.cend(), [dep, providerName, isQuilt](auto o) {
+        auto over = std::find_if(overide.cbegin(), overide.cend(), [dep, providerName, isQuilt](const auto& o) {
             return o.provider == providerName && dep.addonId == (isQuilt ? o.fabric : o.quilt);
         });
         if (over != overide.cend()) {
@@ -207,8 +207,9 @@ Task::Ptr GetModDependenciesTask::prepareDependencyTask(const ModPlatform::Depen
             if (!pDep->version.addonId.isValid()) {
                 if (m_loaderType & ModPlatform::Quilt) {  // falback for quilt
                     auto overide = ModPlatform::getOverrideDeps();
-                    auto over = std::find_if(overide.cbegin(), overide.cend(),
+                    auto over = std::find_if(overide.cbegin(), overide.cend(), [dep, provider](const auto& o) {
-                                             [dep, provider](auto o) { return o.provider == provider.name && dep.addonId == o.quilt; });
+                        return o.provider == provider.name && dep.addonId == o.quilt;
+                    });
                     if (over != overide.cend()) {
                         removePack(dep.addonId);
                         addTask(prepareDependencyTask({ over->fabric, dep.type }, provider.name, level));

launcher/modplatform/atlauncher/ATLPackInstallTask.cpp

@@ -391,7 +391,7 @@ QString PackInstallTask::getVersionForLoader(QString uid)
     return m_version.loader.version;
 }
 
-QString PackInstallTask::detectLibrary(VersionLibrary library)
+QString PackInstallTask::detectLibrary(const VersionLibrary& library)
 {
     // Try to detect what the library is
     if (!library.server.isEmpty() && library.server.split("/").length() >= 3) {

launcher/modplatform/atlauncher/ATLPackInstallTask.h

@@ -105,7 +105,7 @@ class PackInstallTask : public InstanceTask {
    private:
     QString getDirForModType(ModType type, QString raw);
     QString getVersionForLoader(QString uid);
-    QString detectLibrary(VersionLibrary library);
+    QString detectLibrary(const VersionLibrary& library);
 
     bool createLibrariesComponent(QString instanceRoot, std::shared_ptr<PackProfile> profile);
     bool createPackComponent(QString instanceRoot, std::shared_ptr<PackProfile> profile);

launcher/ui/pages/instance/McClient.h

@@ -1,3 +1,4 @@
+#pragma once
 #include <QFuture>
 #include <QJsonDocument>
 #include <QJsonObject>